Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency syntax in EiffelArtifactCreatedEvent #50

Conversation

d-stahl-ericsson
Copy link
Contributor

Proposal for dependency declaration syntax in EiffelArtifactCreatedEvent, as described in #10. This is a very open issue, and I'm creating the pull request mostly to solicit feedback.

The added documentation page should give a decent idea of the reasoning and why it's defined as it is.

Please read, reflect and discuss.

@rogpers-ericsson
Copy link

rogpers-ericsson commented Aug 4, 2016

Need to digest this a bit more but some initial comments:

The descriptive documentation contradicts itself, or is at least a bit confusing. In the beginning there is mention of build and run-time dependencies (as different things). At the end it is stated that there is no (syntactical) difference between those.

On a more philosophical note...

We have worked to get rid of using GAVs for referencing artifacts (and baselines) in BDEs and instead use the corresponding eventId. This has been for consistency - there can only be one way to reference artifacts (and baselines). This makes sense.

Now, with the improved handling of dependencies we have brought back GAVs as "keys" for dependencies. This is, I guess, the simplest way of handling "external" dependencies and version ranges.

This is not a problem per se: compositions are always done with specific versions while dependencies may be more loose and support ranges.

We need to be very pedagogical when explaining this. The question "why can I not use a GAV for defining my composition (when I use it for dependencies)?" will come.

@d-stahl-ericsson
Copy link
Contributor Author

Oops. As you can tell I changed my mind half way through writing the text, and clearly forgot to cover my tracks. Fixed.

Also added some reasoning on why GAVs are the right choice in this case, but not for trace links.

@d-stahl-ericsson d-stahl-ericsson merged commit f780f6a into eiffel-community:topic-drop3 Aug 31, 2016
@d-stahl-ericsson d-stahl-ericsson deleted the topic-drop3-declaredependencies branch September 30, 2016 06:52
@magnusbaeck magnusbaeck added the protocol All protocol changes label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol All protocol changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants