Reference data set and generator #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added obsolete generator script (to be updated) along with dummy events file.
The validation script will no longer simply loop over schemas and attempt to apply to matching example files. Instead it reads all schemas, then reads all examples from all files, including lists of events (as found in examples/flows), then attempts to validate them all. The script also reports warnings for unchecked examples (due to missing schemas). The reason for implementing this change now is to be able to supportdevelopment development of large reference data sets.
d-stahl-ericsson
force-pushed
the
topic-drop3-referencedataset2
branch
from
41f2dc4
to
a52b66c
Compare
|
Hi Daniel , Maybe all that is needed to resolve the conflict is to clarify how to read the link flows with respect to time. |
|
plus it makes it hard to scale the link flow... |
|
Point taken. You should post it as an issue, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a reference data set, consisting of events representing 5000 semi-random iterations of a hypothetical pipeline. Documentation and generator script included. This addresses issue #32.
Also updated the validation script to no longer simply loop over schemas and attempt to apply to matching example files. Instead it reads all schemas, then reads all examples from all files, including lists of events (as found in examples/flows), then attempts to validate them all. The script also reports warnings for unchecked examples (due to missing schemas). The reason for implementing this change now is to be able to supportdevelopment development of large reference data sets.