Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependabot watch workflow files as well #34

Closed
JonasAlfredsson opened this issue Oct 21, 2022 · 2 comments · Fixed by #35
Closed

Make dependabot watch workflow files as well #34

JonasAlfredsson opened this issue Oct 21, 2022 · 2 comments · Fixed by #35

Comments

@JonasAlfredsson
Copy link
Member

Description

In issue #26 dependabot was added for the Go ecosystem, and it appears to have worked well.
It is possible to expand the configuration to also create updates for dependencies defined in the .github/workflows folder, so they are also up to date.

Motivation

With this we will be notified, and a pull request automatically created, every time there is an update to the dependencies.
It will remove the tedious task of manually checking for updates (and performing them), which is great.

Exemplification

After the introduction of #30 dependabot immediately created #31, #32 and #33.
Something similar will probably happen this time around as well.

Benefits

Using the most recent update is probably preferred so that security fixes are added as soon as they are available.

Possible Drawbacks

It could be that updates to dependencies introduce new bugs, and major version bumps may introduce breaking API changes.
However, I think it is better to run into such issues as soon as possible rather than a year down the line when we might have multiple dependencies do major version upgrades.

JonasAlfredsson added a commit to JonasAlfredsson/eiffelevents-sdk-go that referenced this issue Oct 21, 2022
@magnusbaeck
Copy link
Member

LGTM as long as it doesn't also upgrade the compiler version:

- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: "1.17.2"

I suppose it only touches the actions themselves.

@JonasAlfredsson
Copy link
Member Author

If it does something wonky you can actually tune dependabot a bit by just responding to the pull requests it makes.
But I think it will only look at the "uses: " lines when it looks for updates.

JonasAlfredsson added a commit to JonasAlfredsson/eiffelevents-sdk-go that referenced this issue Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants