Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot for the Go ecosystem #30

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

JonasAlfredsson
Copy link
Member

@JonasAlfredsson JonasAlfredsson commented Oct 16, 2022

Applicable Issues

This pull request aims to solve issue #26.

Description of the Change

In issue #26 it is mentioned that we should set up dependabot and see if it makes the work of keeping dependencies up to date easier.
This pull requests configures it to scan the go.mod file to see if anything can updated, and if it is appreciated it can also be configured to monitor the dependencies inside the .github/workflows folder.
For now the cadence is set to weekly, with a limit of max 10 simultaneous pull requests open, but this can be tuned later.

Alternate Designs

Dependabot is a GitHub native functionality, so no other designs were really considered.

Benefits

We get notified when there are updates to dependencies used in this repo, and pull requests are automatically created to solve them.

Possible Drawbacks

We may get spammed with a lot of pull requests (unlikely).
Updating dependencies may break stuff, but hopefully the tests will catch anything of that nature.

Sign-off

Jonas Alfredsson - jonas.alfredsson@axis.com

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by:

@JonasAlfredsson JonasAlfredsson requested a review from a team as a code owner October 16, 2022 09:22
Copy link
Member

@magnusbaeck magnusbaeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, but the commit author should be your firstname.lastname work email since you're contributing this as an employee.

Also, nit, if you adjust the PR description to reference the issue using https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue the issue will automatically be closed and marked as fixed when the PR is merged.

@JonasAlfredsson
Copy link
Member Author

Something like that instead?

@magnusbaeck magnusbaeck merged commit fe83030 into eiffel-community:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants