Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert block hash to number #710

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

ICavlek
Copy link
Contributor

@ICavlek ICavlek commented Jul 2, 2024

Updated check of requested block hash in resolve_block_by_id function

  • Request of block by hash is checked by it's number representation
  • Block root value is returned because of the proof validation
  • Necessary changes in request of block by number

Unit tests for resolve_block_by_id function

  • Test environment - Mock server for Starknet with custom response, state of Helios client
  • User inputs of desired block and check with the response

Update of integration tests in tests/rpc.rs

  • Additional requests by block hash and tag in test_getStorageAt

@ICavlek ICavlek marked this pull request as ready for review July 3, 2024 11:48
@ICavlek ICavlek changed the title [WIP] feat: convert block hash to number feat: convert block hash to number Jul 3, 2024
@ICavlek ICavlek added the feature label Jul 3, 2024
@ICavlek ICavlek requested a review from a team July 3, 2024 11:49
@ICavlek ICavlek linked an issue Jul 3, 2024 that may be closed by this pull request
Copy link
Contributor

@sergey-melnychuk sergey-melnychuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ICavlek ICavlek merged commit b59496d into main Jul 4, 2024
7 checks passed
@ICavlek ICavlek deleted the ic/block_hash_to_number branch July 4, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: block hash to number in proof validation
3 participants