Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: block hash to number in proof validation #675

Closed
Tracked by #678
ICavlek opened this issue Jun 14, 2024 · 0 comments · Fixed by #710
Closed
Tracked by #678

feat: block hash to number in proof validation #675

ICavlek opened this issue Jun 14, 2024 · 0 comments · Fixed by #710
Assignees
@ICavlek
Labels
feature
Milestone
M2: Production Re...

Comments

@ICavlek
Copy link
Contributor

ICavlek commented Jun 14, 2024 •
edited

beerus/src/rpc.rs

Lines 165 to 168 in b78d26f

gen::BlockId::BlockHash { .. } => {
// TODO Find matching block number and resolve it properly
Ok(block_id)
}

@ICavlek ICavlek mentioned this issue Jun 14, 2024
Merged
@sergey-melnychuk sergey-melnychuk added this to the M2: TBD milestone Jun 15, 2024
@sergey-melnychuk sergey-melnychuk changed the title chore: block hash to number in proof validation feat: block hash to number in proof validation Jun 15, 2024
@sergey-melnychuk sergey-melnychuk mentioned this issue Jun 18, 2024
Open
6 tasks
@ICavlek ICavlek linked a pull request Jul 3, 2024 that will close this issue
feat: convert block hash to number #710
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ICavlek ICavlek

Labels
feature
Projects
None yet
Milestone
M2: Production Readiness
Development

Successfully merging a pull request may close this issue.

feat: convert block hash to number eigerco/beerus
2 participants
@sergey-melnychuk @ICavlek