Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut in old Firefox #6

Closed
grahamperrin opened this issue Feb 10, 2019 · 24 comments
Closed

Keyboard shortcut in old Firefox #6

grahamperrin opened this issue Feb 10, 2019 · 24 comments

Comments

@grahamperrin
Copy link

I'd like a tab to pop up in response to a keyboard shortcut.

Comparable (new enhancement request): Keyboard shortcut · Issue #15 · ettoolong/PopupWindow

@eight04
Copy link
Owner

eight04 commented Feb 10, 2019

I think we can add a shortcut to popup/insert back the current tab/popup window.

The shortcut will be configurable after Firefox 66:
https://bugzilla.mozilla.org/show_bug.cgi?id=1303384

@grahamperrin
Copy link
Author

Thanks:

image

I sped through https://github.com/eight04/popup-tab/pull/7/files but (sorry) I can't tell which shortcut you have chosen.

@eight04
Copy link
Owner

eight04 commented Feb 11, 2019

You have to use Firefox 66+ to set the shortcut.

@grahamperrin
Copy link
Author

Ah, thanks for clarification.

I imagined a developer-set preset, effective in 65.0, user-configurable in 66+

Waterfox 56.2.7.1 here, but I don't expect support for this browser.

@eight04
Copy link
Owner

eight04 commented Feb 11, 2019

I'm not familiar with Waterfox. If commands.update is supported, then it is possible to create a configurable shortcut. Otherwise, we can only define a default.

a developer-set preset

Any suggestion?

@eight04 eight04 reopened this Feb 11, 2019
@eight04 eight04 changed the title Keyboard shortcut Keyboard shortcut in old Firefox Feb 11, 2019
@grahamperrin
Copy link
Author

Thanks. Waterfox 56.0 was based on Firefox 56.0.2.

I thought first of Control-Shift-U but https://redd.it/abrv4b reminds me, it's already a standard shortcut for Unicode character composition.


Control-Alt-U maybe?

I have quite a few extensions, at a glance it's uncommon to use Control-Alt:

image

– which might mean, it's a good choice.

On the other hand, maybe there's a good reason (unknown to me on FreeBSD) for avoiding Control-Alt combinations.

I reckon, go for it. Control-Alt-U

FWIW:

@grahamperrin
Copy link
Author

https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/commands/update#Browser_compatibility shows 60 for Firefox so let's assume that commands.update will not be supported by any 56.x version of Waterfox.

@eight04
Copy link
Owner

eight04 commented Feb 12, 2019

Waterfox 56.2.7.1
image

@eight04
Copy link
Owner

eight04 commented Feb 12, 2019

Waterfox doesn't allow us to use Alt as the second modifier:

secondary modifier (optional). If supplied, this must be either "Shift" or (for Firefox ≥ 63) any one of "Ctrl", "Alt", "Command" and "MacCtrl", which has not been used as the main modifier.

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands#Key_combinations

@grahamperrin
Copy link
Author

image

Does that look right?

On FreeBSD-CURRENT here. And I'm almost completely lost in consoles in browsers :-)

@grahamperrin
Copy link
Author

OK so your GitHub ID is eight04, like 804, so maybe this:

Control-Shift-8

image

@eight04
Copy link
Owner

eight04 commented Feb 12, 2019

Can you use keyconfig to change a hotkey defined by a webextension?

I guess I will choose Ctrl+J (Join popup/Jump out window).

@grahamperrin
Copy link
Author

Can you use keyconfig to change a hotkey defined by a webextension?

In my experience, not reliably (not understandably).

Ctrl+J

Re: https://support.mozilla.org/kb/keyboard-shortcuts-perform-firefox-tasks-quickly#w_tools that's for downloads, and (for me) is already in conflict with something else:

image

@eight04
Copy link
Owner

eight04 commented Feb 12, 2019

image
It seems that we can change the hotkey using keyconfig. However, I don't know what will happen if there are multiple hotkeys defined by multiple extensions. The name looks pretty weird.

@grahamperrin
Copy link
Author

Not Control-Shift-U, please, for the reason given at #6 (comment)

@eight04
Copy link
Owner

eight04 commented Feb 12, 2019

Maybe we should not set a default key at all since an unchangeable hotkey is a bad idea. We can revisit this issue after FF66 enters the release channel.

For Waterfox users, here is a custom build that set Ctrl+Shift+8 as the default. You can use the keyconfig addon to change it to anything you like.

After FF66 hits the release channel, I will probably use Ctrl+Shift+O as the default and push the change to AMO, then you can drop the custom build.
popup_tab-0.2.0.zip

@grahamperrin
Copy link
Author

Thanks for the build, I'll test.

Not Control-Shift-O, please; it's in conflict with a browser default in the screenshot at #6 (comment) above.

Here we have a problem with Mozilla's documentation https://support.mozilla.org/kb/keyboard-shortcuts-perform-firefox-tasks-quickly – the same default exists (but is not documented) in Firefox 65.0 in safe mode.

@eight04
Copy link
Owner

eight04 commented Feb 12, 2019

That command had been moved to Ctrl+Shift+B.

@grahamperrin
Copy link
Author

grahamperrin commented Feb 12, 2019

@grahamperrin
Copy link
Author

grahamperrin commented Feb 12, 2019

Ctrl+Shift+B

– has been documented for a long time, but truly it's non-effective in Firefox 65.0 on Linux and Firefox 65.0 on FreeBSD-CURRENT.

Please: is this shortcut effective in your Firefox? If so: which version, on which OS? Clarified: bug 1527337 is a Tier-3 Knowledge Base content issue.

For the purposes of this #6 we should avoid both (a) the documented shortcuts that are presented to users of Windows; and (b) the documented shortcuts that are presented to users of Linux. Use the Editing Tools menu at https://support.mozilla.org/kb/keyboard-shortcuts-perform-firefox-tasks-quickly to disclose customisation for the document (without editing).

@grahamperrin
Copy link
Author

… For Waterfox users, here is a custom build that set Ctrl+Shift+8 as the default. …

Confirmed good with:

  • Waterfox 56.2.7.1 on (unsupported) FreeBSD-CURRENT
  • Waterfox 56.2.7.1 on Lubuntu
  • Firefox 65.0 in Lubuntu.

Thanks! Five gold stars on their way to the reviews area …

@eight04
Copy link
Owner

eight04 commented Feb 13, 2019

Yes, I'm using Windows 7. Both Waterfox and Firefox Dev 66.0b7 use Ctrl+Shift+B to open bookmark manager.

@grahamperrin
Copy link
Author

Thanks again.

There was a subliminal reason for me suggesting
Control-Shift-8 (number 8) … a comparable shortcut with F8 (function key 8) features strongly in KWin:

image

Effect:

image

– an overview of popped-up and other windows.

(More obscurely: I learnt to use function keys in that area of the keyboard back in 2003, when Apple introduced Exposé.)

@grahamperrin
Copy link
Author

I stopped using Waterfox some time ago (only because there's no longer a third party port to FreeBSD.

Without looking in detail at what's above: is there any reason to keep this issue open?

If not, please close – thank you.

@eight04 eight04 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants