feat(env): allow update of existing env vars #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alethenorio
approved these changes
Apr 13, 2022
alethenorio
reviewed
Apr 13, 2022
Edholm
force-pushed
the
feat/update-env-vars
branch
from
b3d2375
to
d016e52
Compare
|
Okay if I merge @alethenorio ? |
alethenorio
reviewed
Apr 20, 2022
This allows you to update existing environment, and service environemnt variables. It also fixes the create function for device service environment variables, which didn't match the API upstream.
Edholm
force-pushed
the
feat/update-env-vars
branch
from
d016e52
to
8e354ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to update existing environment, and service environemnt variables.
It also fixes the create function for device service environment variables, which didn't match the API upstream.
In addition to the unit tests, I have tested all methods manually in another repo.