Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routingv8): do not omit empty lat long json fields #37

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

philiphassel
Copy link
Contributor

Sending a coordinate with either latitude or longitude set to 0 should not omit the corresponding field when converting to json.

Sending a coordinate with either latitude or longitude set to 0 should not omit the corresponding field when converting to json.
@philiphassel philiphassel requested review from a team September 28, 2021 09:38
@codecov-commenter
Copy link

Codecov Report

Merging #37 (bcb12e0) into master (f370dcb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   13.00%   13.00%           
=======================================
  Files          13       13           
  Lines         715      715           
=======================================
  Hits           93       93           
  Misses        607      607           
  Partials       15       15           
Impacted Files Coverage Δ
routingv8/request.go 18.53% <ø> (ø)

@philiphassel philiphassel merged commit 57d28a3 into master Sep 28, 2021
@philiphassel philiphassel deleted the always_send_lat_lng branch September 28, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants