Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation feature #269

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Conversation

OVSofia
Copy link
Member

@OVSofia OVSofia commented Jul 1, 2019

Fixes #267

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #269 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   93.74%   93.75%   +<.01%     
==========================================
  Files          31       31              
  Lines        1135     1136       +1     
==========================================
+ Hits         1064     1065       +1     
  Misses         71       71
Impacted Files Coverage Δ
src/einsteinpy/symbolic/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f25e0...f54213b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #269 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #269      +/-   ##
=========================================
+ Coverage   93.39%   93.4%   +<.01%     
=========================================
  Files          33      33              
  Lines        1136    1137       +1     
=========================================
+ Hits         1061    1062       +1     
  Misses         75      75
Impacted Files Coverage Δ
src/einsteinpy/symbolic/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a66d04e...2c3b573. Read the comment docs.

@ritzvik ritzvik mentioned this pull request Jul 1, 2019
@ritzvik
Copy link
Member

ritzvik commented Jul 1, 2019

This needs a rebase

git pull --rebase upstream master
git push origin documentationFeature -f

-f for force push, as there is change in history.
This time I'm writing out the specific commands, next time onwards you would know what to do when I say rebase :)

@ritzvik
Copy link
Member

ritzvik commented Jul 1, 2019

After this ready for merging

@ritzvik
Copy link
Member

ritzvik commented Jul 1, 2019

@OVSofia
Also, kindly learn what is squashing commits.
https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

Not this time, but I might ask you to squash commits sometime in future.

Thanks

@shreyasbapat
Copy link
Member

I will ask you to do one more rebase :)

I will merge some PR's before this one :/
Sorry for the trouble!

@shreyasbapat
Copy link
Member

LGTM

@shreyasbapat shreyasbapat merged commit 4b79e87 into einsteinpy:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs not present for Ricci Tensor & Vacuum Metrics
3 participants