Feature/separate nunit #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea, thanks! |
|
@haf I'm having a few misgivings on this. While removing a dependency on NUnit from the core stuff is nice, I still need NUnit support for the nuget package. On the other hand, publishing a separate PerfUtil.NUnit sounds like overkill: the addition is too small, nonetheless not entirely trivial. Thoughts? |
|
Why is it too trivial to publish a separate nuget? It's not trivial from a consumer side to get an unneeded dependency and there's no code requirement for the dependency either. I think it's nicer to publish more nugets, thereby having more granular nugets for exactly the type of functionality the consumer is after. |
|
This will probably need a FAKE script. |
|
Done. Nuget has been updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to have this separate since I'm integrating it into Fuchu, Suave and FSharp.Actor.