Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on Java 8 #46

Closed
Stexxen opened this issue Aug 19, 2014 · 4 comments
Closed

Doesn't work on Java 8 #46

Stexxen opened this issue Aug 19, 2014 · 4 comments

Comments

@Stexxen
Copy link

Stexxen commented Aug 19, 2014

Unfortunately it doesn't compile under java 8.
First problem was the Scala version (2.8) is incompatible. I upgraded the support compiler to 2.11 but that doesn't work at all, as some required annotations have been removed (@serialization)
2.10 seems to get further ( The annotations are present, but deprecated) but I then blows up at another error

error: bad symbolic reference. A signature in Generic.class refers to type Collection
in package scala.package which is not available.
It may be completely missing from the current classpath, or the version on
the classpath might be incompatible with the version used when compiling Generic.class.
@davidB
Copy link

davidB commented Oct 1, 2014

Hi,

I'm the original contributor for scala/sbinary (several years ago). Sbinary is no longer use is scala env.
IMHO, scala should be simply remove from the bench.

@cakoose
Copy link
Collaborator

cakoose commented Oct 1, 2014

Just as an FYI, I'm sorta looking into this now.

  • Upgrading to Scala 2.11.2 (though there's a bug in the way it handles
    Java files that I'm trying to work around)
  • Removing sbinary
  • Adding scala-pickling (though there's a bug in the way it's macro
    references classes that I'm trying to fix).

Also, is anybody an SBT expert? I think switching to SBT as a build tool
might improve a few things. Unfortunately, the build is pretty complicated
(since it involves codegen) and I don't think I have the SBT knowledge to
do it myself.

On Wed, Oct 1, 2014 at 4:41 AM, David Bernard notifications@github.com
wrote:

Hi,

I'm the original contributor for scala/sbinary (several years ago).
Sbinary is no longer use is scala env.
IMHO, scala should be simply remove from the bench.


Reply to this email directly or view it on GitHub
#46 (comment)
.

@cakoose
Copy link
Collaborator

cakoose commented Oct 2, 2014

Ok, I upgraded to Scala 2.11.2. Hopefully that works under Java 8, but I
haven't tried.

I filed a bug against scala-pickling. When they fix it, I'll try adding it
to the benchmark.

On Wed, Oct 1, 2014 at 7:23 PM, Kannan Goundan kannan@cakoose.com wrote:

Just as an FYI, I'm sorta looking into this now.

  • Upgrading to Scala 2.11.2 (though there's a bug in the way it handles
    Java files that I'm trying to work around)
  • Removing sbinary
  • Adding scala-pickling (though there's a bug in the way it's macro
    references classes that I'm trying to fix).

Also, is anybody an SBT expert? I think switching to SBT as a build tool
might improve a few things. Unfortunately, the build is pretty complicated
(since it involves codegen) and I don't think I have the SBT knowledge to
do it myself.

On Wed, Oct 1, 2014 at 4:41 AM, David Bernard notifications@github.com
wrote:

Hi,

I'm the original contributor for scala/sbinary (several years ago).
Sbinary is no longer use is scala env.
IMHO, scala should be simply remove from the bench.


Reply to this email directly or view it on GitHub
#46 (comment)
.

@pascaldekloe
Copy link
Collaborator

Works with Java 8 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants