[Daemon] Drop support of XML-RPC #440
Milestone
Comments
|
XML-RPC is already causing compile time failures too, see gentoo/gentoo#18854 (review) |
klondi
added a commit
to klondi/gentoo
that referenced
this issue
Feb 26, 2021
It fails to compile with newer versions of Eiskaltdc++ and upstream is already planning to drop it (see [1]). Patching the daemon to fix these errors is not trivial and this codepath may introduce other issues as it is not well tested. While we are at this, also merge JSON support with the daemon and cli USE flags as there is no point on keeping it as a separated USE flag. If you intend to readd ZML-RPC, please first write a patch that addresses the compilation issues. [1] eiskaltdcpp/eiskaltdcpp#440 Package-Manager: Portage-3.0.13, Repoman-3.0.2 Signed-off-by: Francisco Blas Izquierdo Riera (klondike) <klondike@gentoo.org>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this issue
Feb 28, 2021
It fails to compile with newer versions of Eiskaltdc++ and upstream is already planning to drop it (see [1]). Patching the daemon to fix these errors is not trivial and this codepath may introduce other issues as it is not well tested. While we are at this, also merge JSON support with the daemon and cli USE flags as there is no point on keeping it as a separated USE flag. If you intend to readd ZML-RPC, please first write a patch that addresses the compilation issues. [1] eiskaltdcpp/eiskaltdcpp#440 Package-Manager: Portage-3.0.13, Repoman-3.0.2 Signed-off-by: Francisco Blas Izquierdo Riera (klondike) <klondike@gentoo.org> Closes: #18854 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All official builds of
eiskaltdcpp-daemonare built only with JSON-PRC support during long time. Unused code should be removed before3.0.0release.The text was updated successfully, but these errors were encountered: