Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce @TargetLocations meta-annotation #339

Merged
merged 54 commits into from
Oct 1, 2023

Conversation

AndrewShf
Copy link
Member

@AndrewShf AndrewShf commented Sep 29, 2022

Enforce meta annotation @TargetLocations. Validate locations listed in file TypeUseLocation.java

This PR is related to #349 (optionally warn about redundant annotations).
This PR aims at forbidding certain qualifiers from being applied to the program ("apply" means that the qualifier cannot be written in the source code explicitly nor be inferred to be placed in the code implicitly). The other PR warns about explicitly written qualifiers in the code if they are the same as the default qualifiers would be applied.

Correponding changes in other repos:
Universe: https://github.com/opprop/universe/pull/59/files
CFI: opprop/checker-framework-inference#413

@sonatype-lift
Copy link

sonatype-lift bot commented Sep 29, 2022

⚠️ 97 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@wmdietl wmdietl changed the title enforce meta annotation TargetLocations Enforce TargetLocations meta-annotation Nov 15, 2022
@wmdietl wmdietl assigned AndrewShf and unassigned wmdietl Sep 27, 2023
@AndrewShf AndrewShf assigned wmdietl and unassigned AndrewShf Sep 30, 2023
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this hard issue!
I left one javadoc improvement comment, please fix that in a separate PR.

@wmdietl wmdietl merged commit c57051c into eisop:master Oct 1, 2023
42 of 43 checks passed
@AndrewShf AndrewShf deleted the enforce-targetlocations branch October 3, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants