Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cleaning the project #502

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Ao-senXiong
Copy link
Member

@Ao-senXiong Ao-senXiong commented May 26, 2023

Delete the tests/build directories when cleaning the project.

Fixes #413.

@wmdietl wmdietl changed the title improve gradle option clean Improve cleaning the project May 26, 2023
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this issue!
As discussed, please also make sure the Makefile-based tests delete their generated files.

@@ -221,8 +221,8 @@ artifacts {
}

clean {
delete "${projectDir}/dist"
delete 'tests/calledmethods-delomboked'
delete('${projectDir}/dist')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this uniform is good, it just needs to continue using double quotes, otherwise the string interpolation won't work.

@@ -7,6 +7,7 @@ include 'checker-qual'
include 'checker-qual-android'
include 'checker-util'
include 'framework-test'
include 'docs'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no build.gradle in the docs subdirectory. What does this do?

@Ao-senXiong Ao-senXiong marked this pull request as draft July 22, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve cleaning the project
2 participants