Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DetailedTestDiagnostic #758

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

rohan-shettyy
Copy link

Create DetailedTestDiagnostic class that extends TestDiagnostic. Will be created for Java diagnostic messages when -Adetailedmsgtext flag is used.

@Ao-senXiong
Copy link
Member

@rohan-shettyy Could you check the log and add some javadoc to the files?

git diff 32641079504e1f5e5d01b36636dfef94478cf966...ee54cd4e61fa6fd53a3f70c45e32f65eb927e54b > /tmp/diff.txt
framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:49:5: missing documentation for getAdditionalTokens
framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:53:5: missing documentation for getStartPosition
framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:57:5: missing documentation for getEndPosition
framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:61:5: missing documentation for getErrorKey
+ status=1
+ ./gradlew javadocDoclintAll --console=plain --warning-mode=all
+ true
+ /__w/1/s/checker/bin-devel/.plume-scripts/ci-lint-diff /tmp/warnings-jda.txt
git diff 32641079504e1f5e5d01b36636dfef94478cf966...ee54cd4e61fa6fd53a3f70c45e32f65eb927e54b > /tmp/diff.txt
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:31: warning: no @param for file
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:31: warning: no @param for lineNo
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:31: warning: no @param for kind
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:31: warning: no @param for errorKey
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:31: warning: no @param for additionalTokens
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:31: warning: no @param for startPosition
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:31: warning: no @param for endPosition
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:31: warning: no @param for readableMessage
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:31: warning: no @param for isFixable
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:49: warning: no comment
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:57: warning: no comment
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:61: warning: no comment
/__w/1/s/framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/DetailedTestDiagnostic.java:53: warning: no comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants