Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a mistake in Deepfool implementation? #15

Closed
saifullah3396 opened this issue Sep 21, 2022 · 1 comment
Closed

Is there a mistake in Deepfool implementation? #15

saifullah3396 opened this issue Sep 21, 2022 · 1 comment

Comments

@saifullah3396
Copy link

I believe there is a mistake in this line in adversarial_deepfool.py
if value_i < value_l:
ri = value_i/np.linalg.norm(wi.numpy().flatten()) * wi
value_l = value_i # <--- this line should be added here since otherwise,t value_i is just always the last value in the for loop?

@ej0cl6
Copy link
Owner

ej0cl6 commented Oct 3, 2022

Thanks for pointing out this. Just fixed it.

@ej0cl6 ej0cl6 closed this as completed Oct 3, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants