Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silently fails when the bucket_count < 3 #15

Closed
jdly opened this issue Sep 4, 2014 · 1 comment · Fixed by #16
Closed

Silently fails when the bucket_count < 3 #15

jdly opened this issue Sep 4, 2014 · 1 comment · Fixed by #16

Comments

@jdly
Copy link
Contributor

jdly commented Sep 4, 2014

In the add function, the next 2 buckets are deleted so when there are < 3 buckets, add does nothing since the bucket that was added to is immediately deleted.

The initialize function should probably check for this condition and raise the appropriate error.
jdly added a commit to jdly/ratelimit that referenced this issue Sep 4, 2014
@jdly
Raise error if bucket_count too small; fixes ejfinneran#15
9161b0a 
Fixes ejfinneran#15
@jdly jdly mentioned this issue Sep 4, 2014
Merged
@ejfinneran
Copy link
Owner

Fix released in 1.0.2.

https://github.com/ejfinneran/ratelimit/releases/tag/v1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise error if bucket_count too small; fixes #15 jdly/ratelimit
2 participants
@ejfinneran @jdly