New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some code, improve debug info in fleche #145

Merged

ejgallego merged 1 commit into ejgallego:main from artagnon:noexcept

Jan 5, 2023

Collaborator

artagnon commented Jan 3, 2023

No description provided.

ejgallego requested changes

View reviewed changes

Owner

ejgallego left a comment

Instead of duplicate the find check at every place the approach in #141 is preferred.

Owner

ejgallego commented Jan 3, 2023

Ok, you can rebase on top of #146

ejgallego reviewed

View reviewed changes

fleche/doc.ml Outdated Show resolved Hide resolved

ejgallego reviewed

View reviewed changes

fleche/memo.ml Outdated Show resolved Hide resolved

ejgallego reviewed

View reviewed changes

fleche/doc.ml Outdated Show resolved Hide resolved

ejgallego reviewed

View reviewed changes

fleche/doc.ml Outdated Show resolved Hide resolved

ejgallego reviewed

View reviewed changes

fleche/doc.ml Outdated Show resolved Hide resolved

artagnon changed the title ~~Never have coq-lsp throw an exception~~ Clean up some code, improve debug info in fleche

Collaborator Author

artagnon commented Jan 3, 2023

All fixed.

ejgallego self-assigned this

ejgallego added this to the 0.1.2 milestone

ejgallego approved these changes

View reviewed changes

Owner

ejgallego left a comment

Thanks, rebased on top of #148 , the extra verbosity of print_file:true didn't work well in my setup.

ejgallego added part: lsp server kind: internal labels


          [fleche] tweak to debug info

001556f

ejgallego merged commit d0b1f16 into ejgallego:main

ejgallego added a commit that referenced this pull request


          [controller] Handle failing requests better.

cf2ff0b

This is a start to handle Coq Internal errors better. Some changes
were already in different form in the first versions of #145

c.f. #91

ejgallego added a commit that referenced this pull request


          [controller] Handle failing requests better.

a50e3d6

This is a start to handle Coq Internal errors better. Some changes
were already in different form in the first versions of #145

c.f. #91

artagnon deleted the noexcept branch

January 11, 2023 11:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment