[controller] Allow to postpone and cancel requests #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
reviewed
Jan 3, 2023
ejgallego
force-pushed
the
document_symbol_delay
branch
2 times, most recently
from
ee99281
to
9449b8d
Compare
ejgallego
force-pushed
the
document_symbol_delay
branch
4 times, most recently
from
b491065
to
6c01fe6
Compare
ejgallego
changed the title
ejgallego
force-pushed
the
document_symbol_delay
branch
2 times, most recently
from
200b2df
to
c36a614
Compare
Some requests need to be delayed until the document is ready, such as `documentSymbols`. In order to do this, we allow to postpone requests, and `Doc_manager.check` will now return the list of requests pending for a given document. The implementation is lightweight and quite a prototype, but should serve as a basis for more advanced stuff. Closes #124.
ejgallego
force-pushed
the
document_symbol_delay
branch
from
c36a614
to
2ce9b24
Compare
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Jan 15, 2023
CHANGES: ---------------------- - Much improved handling of Coq fatal errors, the server is now hardened against them (@ejgallego, ejgallego/coq-lsp#155, ejgallego/coq-lsp#157, ejgallego/coq-lsp#160, fixes ejgallego/coq-lsp#91) - `coq-lsp` now follows the LSP specification regarding initialization strictly (@ejgallego, ejgallego/coq-lsp#168) - New setting for goals to be updated when the selection changes due to a command; this makes VsCodeVim cursor tracking work; thanks to Cactus (Anton) Golov for detailed bug reporting and testing (@ejgallego, @jesyspa, ejgallego/coq-lsp#170, fixes ejgallego/coq-lsp#163) - `coq-lsp` will now warn the user when two files have been opened simultaneously and the parser may go into a broken state :/ (@ejgallego, ejgallego/coq-lsp#169) - Implement request postponement and cancellation. Thus `documentSymbols` will now be postponed until the document is ready, (@ejgallego, ejgallego/coq-lsp#141, ejgallego/coq-lsp#146, fixes ejgallego/coq-lsp#124) - Protocol and VS Code interfaces now support shelved and given_up goals (@ejgallego, ejgallego/coq-lsp#175) - Allow to postpone requests to wait for data to become available on document points; this is implemented to provide a nicer "show goals while I type" experience. Client default has been changed to "show goals on mouse, click, typing, and cursor movement) (@ejgallego, ejgallego/coq-lsp#177, ejgallego/coq-lsp#179) - Store stats per document (@ejgallego, ejgallego/coq-lsp#180, fixes ejgallego/coq-lsp#173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some requests need to be delayed until the document is ready, such as
documentSymbols. In order to do this, we allow to postpone requests,and
Doc_manager.checkwill now return the list of requests pendingfor a given document.
The implementation is lightweight and quite a prototype, but should
serve as a basis for more advanced stuff.
Closes #124.