Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right-to-left layout support #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mamins1376
Copy link

You can use this by setting config.extra.rtl to true.

@vercel
Copy link

vercel bot commented Jan 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ejmg/zerm/4dn97bfPNgmzfwzmWZadrPvU9prM
✅ Preview: https://zerm-git-fork-mamins1376-master-ejmg.vercel.app

@ejmg
Copy link
Owner

ejmg commented Jan 23, 2021 via email

@mamins1376
Copy link
Author

Here you go. Also I did some sass/_variables.scss clean up and wrote an article regarding RTL support, Feel free to drop or change it. The link in the article needs to be updated when vercel config is done and both layouts are available.

Importing a SCSS file containing rules results in duplication of styles,
and one can verify this by looking at the browser's style inspection
tool. This commit extracts rules from _variables.scss into _root.scss.
@mamins1376
Copy link
Author

Why is this hanging around for so long?

@ejmg
Copy link
Owner

ejmg commented Oct 21, 2021

because between my job and all the other PR's that have come through, i've unfortunately left this one behind. i'll try to make a point of reviewing this PR on the weekend. what i said before about this PR remains true, your effort and time is truly appreciated 🙂

@ejmg ejmg self-assigned this Oct 21, 2021
@ejmg ejmg added the enhancement New feature or request label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants