Separate binary and source Node installation steps #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes binary for Windows properly installed in ./bin/
Closed
|
Test fails, because Linux binary is unpacked into |
|
Fixing... |
|
Well, it is ready to be merged for #140 even if coverage percentage fails. I removed some code duplication, but that's all I can do. |
ekalinin
added a commit
that referenced
this pull request
Feb 13, 2016
Separate binary and source Node installation steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
nodeenvdownloadnode.exedirectly into bin/ directory.Linux download should get and unpack binary files directly without additional copy operation. This reuses download src logic as before, but needs to be checked that I didn't broke anything there.