Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-430 - Add shared node setup / module cache #431

Merged
merged 3 commits into from
May 22, 2024

Conversation

huntharo
Copy link
Contributor

@huntharo huntharo commented May 22, 2024

Summary

Before

  • 0 seconds to setup node 16
  • 7 seconds to install modules from scratch
  • Repeated on every build

https://github.com/ekalinin/sitemap.js/actions/runs/9183238710/job/25253577373

image

After

  • 4 seconds to restore modules from cache

https://github.com/ekalinin/sitemap.js/actions/runs/9184692506/job/25257439376

image

@huntharo huntharo force-pushed the issue-430/shared-node-setup branch 2 times, most recently from 9513b7f to c727afc Compare May 22, 2024 02:48
@huntharo huntharo force-pushed the issue-430/shared-node-setup branch from c727afc to 0e18b07 Compare May 22, 2024 02:58
@huntharo
Copy link
Contributor Author

@derduher this is ready for review. It helps with the next thing I'm going to do in #430 which is to add a job to publish the docs. It will be a benefit to have the node install / deps install / cache restore code consolidated for that.

@derduher derduher merged commit a4381cc into ekalinin:master May 22, 2024
2 checks passed
@huntharo huntharo deleted the issue-430/shared-node-setup branch May 22, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants