fix(snapshot): correct snapshot comparison with carriage returns #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leguellec
force-pushed
the
fix-snapshot-and-carriage-returns
branch
2 times, most recently
from
8d5c877
to
336277c
Compare
leguellec
force-pushed
the
fix-snapshot-and-carriage-returns
branch
3 times, most recently
from
6f96f1c
to
a84c33e
Compare
leguellec
force-pushed
the
fix-snapshot-and-carriage-returns
branch
2 times, most recently
from
431dfea
to
d707c42
Compare
leguellec
force-pushed
the
fix-snapshot-and-carriage-returns
branch
from
d707c42
to
74f92fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Veggies use a method named
normalizeNewlineson the content before writing the snapshot (and it replace carriage return and line feed (\r\n) with line feed (\n)), . Unfortunately this method is not used on the content when we try to compare it to the previously generated snapshot, and the comparison fail. The change is to applynormalizeNewlineson the content in theexpectToMatchmethod from the snapshot extensionTest plan
Not sure if i put test in the right place ... maybe have to change it :) . Add one functional test in the example sections, but there is also functional test in tests folder but only for snapshot extension ( and don't look very relevant). By the way test a content with CR LF and expect the comparison with the snapshot to match