New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the type of generalBracket, fixes #63 #64
Merged
Merged
Changes from 11 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ca70699
SomeMSpec
gelisam 04a5988
name the MSpecs
gelisam dd90823
a series of tests about detectable effects
gelisam e175f61
test that the release error wins
gelisam 7e9b7df
move the CatchT warning to the instance documentation
gelisam 20833ab
explain the difference with lifted-base
gelisam 9e42dd8
change the type of generalBracket, fixes #63
gelisam 6f51794
MonadMask instance for MaybeT
gelisam b64993d
onException vs onError
gelisam 1cacf63
use return instead of pure
gelisam 5c725b7
add the changes to the changelog
gelisam 82659ea
add onError to the changelog
gelisam bd6a570
add Show instance for ExitCase
gelisam 4352de7
Explicitly state which constructors of ExitCase correspond to throwE …
gelisam 3a7e35b
typos
gelisam 2aa7dae
next version is 0.10.0
gelisam 9d4ee1b
onError @since 0.10.0
gelisam cd317d8
spell out the difference between onError and onException
gelisam 562b331
swap the arguments of generalBracket to match bracket
gelisam 594477e
explain why users probably don't want to call generalBracket directly
gelisam 9e168e8
reminder to keep the doc in sync with the implementation
gelisam c1a5014
@since annotations for MaybeT and ExceptT
gelisam eb13cec
adjust phrasing
gelisam 1bae026
rename the type variables in bracket*
gelisam 7d74727
import Control.Applicative when required
gelisam dc3e243
use liftM instead of fmap, for older GHCs
gelisam 91fe5e5
also import Control.Applicative for GHC-7.4
gelisam File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defintely version 0.10.0, as this will require a major version bump.