Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the type of generalBracket, fixes #63 #64

Merged
merged 27 commits into from Mar 9, 2018
Merged

change the type of generalBracket, fixes #63 #64

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ca70699
SomeMSpec
gelisam Mar 6, 2018
04a5988
name the MSpecs
gelisam Mar 6, 2018
dd90823
a series of tests about detectable effects
gelisam Mar 6, 2018
e175f61
test that the release error wins
gelisam Mar 6, 2018
7e9b7df
move the CatchT warning to the instance documentation
gelisam Mar 7, 2018
20833ab
explain the difference with lifted-base
gelisam Mar 7, 2018
9e42dd8
change the type of generalBracket, fixes #63
gelisam Mar 7, 2018
6f51794
MonadMask instance for MaybeT
gelisam Mar 7, 2018
b64993d
onException vs onError
gelisam Mar 7, 2018
1cacf63
use return instead of pure
gelisam Mar 7, 2018
5c725b7
add the changes to the changelog
gelisam Mar 7, 2018
82659ea
add onError to the changelog
gelisam Mar 8, 2018
bd6a570
add Show instance for ExitCase
gelisam Mar 8, 2018
4352de7
Explicitly state which constructors of ExitCase correspond to throwE …
gelisam Mar 8, 2018
3a7e35b
typos
gelisam Mar 8, 2018
2aa7dae
next version is 0.10.0
gelisam Mar 8, 2018
9d4ee1b
onError @since 0.10.0
gelisam Mar 8, 2018
cd317d8
spell out the difference between onError and onException
gelisam Mar 8, 2018
562b331
swap the arguments of generalBracket to match bracket
gelisam Mar 8, 2018
594477e
explain why users probably don't want to call generalBracket directly
gelisam Mar 8, 2018
9e168e8
reminder to keep the doc in sync with the implementation
gelisam Mar 8, 2018
c1a5014
@since annotations for MaybeT and ExceptT
gelisam Mar 8, 2018
eb13cec
adjust phrasing
gelisam Mar 8, 2018
1bae026
rename the type variables in bracket*
gelisam Mar 8, 2018
7d74727
import Control.Applicative when required
gelisam Mar 9, 2018
dc3e243
use liftM instead of fmap, for older GHCs
gelisam Mar 9, 2018
91fe5e5
also import Control.Applicative for GHC-7.4
gelisam Mar 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.markdown
View file
Open in desktop
@@ -1,3 +1,15 @@
0.10.0
------
* Fix a regression in 0.9.0 whereby the non-IO effects in `bracket`'s `use`
action were not visible to the `release` action, and the non-IO effects in the
`release` action were not visible after the `bracket` call.
* The type of `generalBracket` was changed in order to restore those non-IO
effects, so if you are a library author that provides a `MonadMask` instance,
you will need to update your implementation of this method.
* Add `MonadMask` instance for `MaybeT`
* Add `onError` function whose action also runs on errors which are not
exceptions, such as a `Nothing` or a `Left`.

0.9.0
-----
* Add `generalBracket` to the `MonadMask` typeclass, allowing more
Expand Down