Make Equality poly-kinded #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treeowl
force-pushed
the
polyequality
branch
2 times, most recently
from
1c5493c
to
c206496
Compare
Allow `Equality s t a b` to prove `s ~ a` and `t ~ b` whenever `s` and `a` have the same kind and `t` and `b` have the same kind. Fixes ekmett#605 Note: For GHC 7.8 and later, this changes the type of `AnEquality` in a non-backwards-compatible way, but this likely won't affect much code.
treeowl
force-pushed
the
polyequality
branch
2 times, most recently
from
9af301d
to
b4558c4
Compare
Add tests to ensure sane things typecheck. Equality is now polykinded on GHC >= 7.6, and more so on GHC >= 7.8.
|
Is anything else needed here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
Equality s t a bto proves ~ aandt ~ bwheneversandahave the same kind andtandbhave the same kind.Fixes #605
Specifically, change the definition of
Equalitytofor
GHC >= 7.8and tofor
GHC==7.6,and the definition of
AnEqualitytofor all versions (with appropriate kind signatures for 7.6+).