Add traversalUnion to Control.Lens.Unsound #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From my position, "Traversing the same entry twice is not lawful." is hearsay: Ctrl-F 'no duplicates' on https://artyom.me/lens-over-tea-2 This implementation looks to me like an inefficient proof of concept.
ekmett's word is law around these parts :P
|
Not keen on the name and may change it, but the functionality is definitely worth adding. |
RyanGlScott
added a commit
that referenced
this pull request
May 1, 2019
RyanGlScott
added a commit
that referenced
this pull request
May 19, 2019
Per edwardk's suggestion: ``` 07:10:19 <RyanGlScott> Unrelated question: do you have an opinion on what the name of `traversalUnion` should be? #778 You expressed a tentative desire to rename this, so I'd hate to release `lens-4.18` without coming to a conclusion on this 07:11:40 <edwardk> i usually like to stick to one word names in lens, lets see 07:12:50 <edwardk> adjoin or abut? i guess adjoin 07:13:24 <RyanGlScott> Sounds good to me 07:13:29 <edwardk> abut is too short for something janky =) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my position, "Traversing the same entry twice is not lawful." is hearsay: Ctrl-F
no duplicateson https://artyom.me/lens-over-tea-2This implementation looks to me like an inefficient proof of concept.