Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hid null from Foldable #8

Merged
merged 1 commit into from
Jul 1, 2015
Merged

Conversation

luke-clifton
Copy link
Contributor

In Data/Rope/Internal.hs. It was clashing with Data.FingerTree.null.

@adinapoli
Copy link
Collaborator

Is this needed though only with version of GHC >= 7.8.x?
Data.Foldable.null was added in base-4.8.0.0:

http://hackage.haskell.org/package/base-4.7.0.0/docs/Data-Foldable.html
http://hackage.haskell.org/package/base-4.8.0.0/docs/Data-Foldable.html

IMHO a better fix would be to import qualified Data.Foldable and Data.FingerTree with different names (not using F for both). This will work across all the versions of GHC & base.

What Mr. @ekmett reckon?

@luke-clifton
Copy link
Contributor Author

It is OK to hide identifiers that don't exist. And it was the easier option :lazy:

@adinapoli
Copy link
Collaborator

Ok, wasn't 100% sure on top of my mind if GHC would have barked at us in trying to hide identifiers which don't exist. In that case I will go on and merge.

adinapoli added a commit that referenced this pull request Jul 1, 2015
@adinapoli adinapoli merged commit 4e966c8 into ekmett:master Jul 1, 2015
@ekmett
Copy link
Owner

ekmett commented Jul 1, 2015

It is OK to hide identifiers that don't exist.

Only on newer GHCs.

Doing so shuts off access to old versions of GHC.

@adinapoli
Copy link
Collaborator

@ekmett Damn, I was right. @luke-clifton Could you send us another PR to amend the changes and roll out my proposed fix?

@luke-clifton
Copy link
Contributor Author

@adinapoli Oh, damn, sorry. I didn't realize that was a new feature. I will do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants