Fixing Rueidis store implementation #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @eko , thanks for doing that and sorry for taking so long to include the tests.
I'm adding a new test for NotFound, just to ensure it is working as intended. Also, fixing the idea of the
clientExpiration
option I've done in the previous proposal. The idea here is to keep theexpiration
using TTL (server-side), but give an option to the user to use a different expiration time for the server-assisted client cache (more info on the link below).Commit notes:
Adding ClientSideCacheExpiration option for rueidis, tweaking tests and benchmarks.
Benchmark Results: