Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for 1.19 #5536

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

neha-viswanathan
Copy link
Contributor

@neha-viswanathan neha-viswanathan commented Jul 24, 2022

fixes #5521

Description

remove support for 1.19

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested test.txt
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Himangini
Copy link
Collaborator

Thanks for the PR 🎉 Can you add the output of your manual testing as well, please?

@neha-viswanathan
Copy link
Contributor Author

Thanks for the PR 🎉 Can you add the output of your manual testing as well, please?

done @Himangini

Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally 🎉

pr/5536 ✔ $ ./eksctl create cluster --name test-gini --version 1.19
2022-08-03 13:13:14 [ℹ]  eksctl version 0.109.0-dev+7b535518d.2022-08-03T13:10:01Z
2022-08-03 13:13:14 [ℹ]  using region us-east-1
Error: invalid version, 1.19 is no longer supported, supported values: 1.20, 1.21, 1.22
see also: https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html

Can you remove sample-1.19.json file too please. 👍🏻

Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove sample-1.19.json file and it is good to go 👍🏻

@neha-viswanathan
Copy link
Contributor Author

neha-viswanathan commented Aug 3, 2022

Need to remove sample-1.19.json file and it is good to go 👍🏻

@Himangini It looks like this file is needed for the coreDNS tests. Do I still need to remove it?

@Himangini
Copy link
Collaborator

Need to remove sample-1.19.json file and it is good to go 👍🏻

@Himangini It looks like this file is needed for the coreDNS tests. Do I still need to remove it?

oops my bad, i made a typo 🙈 Can you remove sample-1.18.json please?

Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

There's user-facing documentation on managed nodegroups that is still using 1.19 as an example, but I think we can leave it as it's mainly for showing the format of the release version.

@cPu1 cPu1 changed the title remove support for 1.19 Remove support for 1.19 Aug 8, 2022
@cPu1 cPu1 marked this pull request as draft August 8, 2022 08:16
@cPu1 cPu1 marked this pull request as ready for review August 8, 2022 08:16
@cPu1 cPu1 enabled auto-merge (squash) August 8, 2022 08:17
@cPu1 cPu1 closed this Aug 8, 2022
auto-merge was automatically disabled August 8, 2022 08:18

Pull request was closed

@cPu1 cPu1 reopened this Aug 8, 2022
@cPu1 cPu1 enabled auto-merge (squash) August 8, 2022 08:18
@cPu1 cPu1 disabled auto-merge August 8, 2022 08:36
@cPu1 cPu1 removed the request for review from nikimanoledaki August 8, 2022 08:49
@cPu1 cPu1 closed this Aug 8, 2022
@cPu1 cPu1 reopened this Aug 8, 2022
@cPu1
Copy link
Collaborator

cPu1 commented Aug 8, 2022

GitHub has been acting weird on this PR, it's stuck on "Waiting for status to be reported", and won't let me merge it.

@Himangini Himangini changed the title Remove support for 1.19 WIP Remove support for 1.19 Aug 8, 2022
@Himangini
Copy link
Collaborator

@wip ready for review

@cPu1 cPu1 merged commit a5e7535 into eksctl-io:main Aug 8, 2022
@Himangini Himangini changed the title WIP Remove support for 1.19 Remove support for 1.19 Aug 8, 2022
@toabctl
Copy link
Contributor

toabctl commented Aug 22, 2022

@Himangini @cPu1 why did you remove support for 1.19? This is still supported by EKS . See https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Remove support for EKS 1.19
4 participants