-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for 1.19 #5536
Remove support for 1.19 #5536
Conversation
73a1025
to
c595441
Compare
Thanks for the PR 🎉 Can you add the output of your manual testing as well, please? |
done @Himangini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified locally 🎉
pr/5536 ✔ $ ./eksctl create cluster --name test-gini --version 1.19
2022-08-03 13:13:14 [ℹ] eksctl version 0.109.0-dev+7b535518d.2022-08-03T13:10:01Z
2022-08-03 13:13:14 [ℹ] using region us-east-1
Error: invalid version, 1.19 is no longer supported, supported values: 1.20, 1.21, 1.22
see also: https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html
Can you remove sample-1.19.json
file too please. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove sample-1.19.json
file and it is good to go 👍🏻
@Himangini It looks like this file is needed for the coreDNS tests. Do I still need to remove it? |
oops my bad, i made a typo 🙈 Can you remove |
7b53551
to
ef133c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
There's user-facing documentation on managed nodegroups that is still using 1.19 as an example, but I think we can leave it as it's mainly for showing the format of the release version.
GitHub has been acting weird on this PR, it's stuck on "Waiting for status to be reported", and won't let me merge it. |
@wip ready for review |
@Himangini @cPu1 why did you remove support for 1.19? This is still supported by EKS . See https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html |
fixes #5521
Description
remove support for 1.19
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
) and kind (e.g.kind/improvement
)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯