Standardize cluster / nodegroup version before doing validations and … #5946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes https://github.com/weaveworks/eksctl-private/issues/471
When setting default
containerRuntime
and doing similar validation, we are currently comparing theclusterVersion
withDockershimDeprecationVersion
(i.e.1.24
). However this comparison turns out to be troublesome, asclusterVersion
at that point doesn't always have a numeric format (e.g.1.22
), it can also be""
,auto
orlatest
. This PR standardises the version before doing the comparison.Manual tests
1. Try to create a cluster on
1.24
with anodeGroup
withcontainerRuntime: dockerd
2. Try to create a cluster on
1.24
with anodeGroup
without specifyingcontainerRuntime
explicitlyAnd now check the nodegroup
containerRuntime
was set tocontainerd
3. Try to add a second
nodeGroup
to the cluster, withcontainerRuntime: dockerd
, without setting cluster version.This
create nodegroup
command shall fetch version number as1.24
from control plane and realise the nodegroup can't be created.Checklist
README.md
, or theuserdocs
directory)area/nodegroup
) and kind (e.g.kind/improvement
)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯