-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The dependencies are not well fulfilled. #117
Comments
Thanks for filling up the issue @elector102 : Check #118 |
What is the issue? Now I am realizing that it is ok that |
Oh yeat it is being used when finding the controller's parameters
|
There is another occurency: https://github.com/Ekumen-OS/andino/blob/humble/andino_description/urdf/andino.urdf.xacro#L84-L87 That imports files from #118 deals with the issue, but the urdf files need to be ordered to solve this problem. |
<xacro:include filename="$(find ${package_name})/urdf/include/andino_control.urdf.xacro" /> Here It is true though that if we are strict we could move the However, based on taking a look at other robots descriptions, in general they add the ros control stuff within the base urdf description and it is quite accepted. |
Pinging @agalbachicar to define the bug if any. I will close this otherwise |
Environment
Description
We are having some dependencies issues using humble branch on a CI. You can see the current dependencies on that image:
![Screenshot from 2023-07-13 14-09-52](https://private-user-images.githubusercontent.com/5404364/253354984-6013f230-bb43-4dc8-b65b-07cfe7d2bc49.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMTAxOTcsIm5iZiI6MTcyNDMwOTg5NywicGF0aCI6Ii81NDA0MzY0LzI1MzM1NDk4NC02MDEzZjIzMC1iYjQzLTRkYzgtYjY1Yi0wN2NmZTdkMmJjNDkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDY1ODE3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTY0NDdjNTI1NzMxZThjMWRiODU3NjY1NWM1NzRiN2Q3NDY0NTAzZWE1NmQ2Zjc5Mzk3OGJkYTYyMDczYzE1YyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.3tUJ0o7eM8ThunAhISxKHgJHNNp7kmSVjv-54htW_Hs)
The problem is that andino Gazebo and andino description depend on andino control, and this dependency is fulfilled indirectly.
on the CI we run to compile and then run the test the following:
colcon build --packages-up-to andino_gazebo aws_robomaker_small_warehouse_world andino_master --event-handlers console_cohesion+
and then:
colcon test --packages-select andino_gazebo aws_robomaker_small_warehouse_world andino_master --event-handlers console_cohesion+
where andino_master are gazebo tests.
With that the dependency of andino gazebo is not fulfilled and CI fail
The text was updated successfully, but these errors were encountered: