Better amount/balance comparison in Letterable#letterable_items

ekylibre · Jan 6, 2017 · 9592241 · 9592241
1 parent 91f7b06
commit 9592241
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/models/concerns/letterable.rb b/app/models/concerns/letterable.rb
@@ -36,8 +36,8 @@ def letterable_items(bank_statement_items)
     return false unless mode.cash_id == bank_statement.cash_id
 
     items = BankStatementItem.where(id: bank_statement_items)
-    bank_items_balance = items.sum(:debit) - items.sum(:credit)
-    return false unless -relative_amount == bank_items_balance
+    bank_items_balance = items.sum(:credit) - items.sum(:debit)
+    return false unless relative_amount == bank_items_balance
     items
   end
 end