Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixedAssets that are on closed financial periods can be changed to "in use" state by the user, ineffectively. #2024

Closed
Zank94 opened this issue Jul 20, 2017 · 0 comments

Comments

@Zank94
Copy link
Contributor

Zank94 commented Jul 20, 2017

screenshot from 2017-07-20 18-20-54

Every year the previous FinancialYear is closed, this prevents further modification, suppression or addition of JournalEntrys on that time period to allow accounting reviews to take place.

A FixedAsset creates several FixedAssetDepreciations when changed from the draft state to the in_use state. Those FixedAssetDepreciations will then create JournalEntrys at the appropriate date and time. When those dates are in the middle of closed FinancialYears, they are prevented from doing so, raising an error.

This prevents the FixedAsset from changing states, so the user should not be able to change state and be warned why.

1- How to reproduce?

Create a FixedAsset whose started_on is situated in the middle of a FinancialYear, go to the FixedAsset #show view, the "In Use" button will be green, clicking on it does nothing and does not switch the state to in_use.

2- What is really expected?

When you go to the FixedAsset view, the button should be disabled and a warning flash message be there:

  • in English: "The fixed asset's duration spans across closed financial periods."
  • in French: "L'immobilisation se déroule sur des périodes comptables clôturée."

3- How to test it?

Create a FixedAsset whose started_on is situated in the middle of a FinancialYear, go to the FixedAsset #show view, the "In Use" button should be grayed out and unusable and a flash message should be warning you the fixed asset spans across closed periods.

@Aquaj Aquaj changed the title Error message missing when user tries to update fixed asset state from 'draft' to 'in_use' if 'started_on' is anterior to financial closure FixedAssets that are on closed financial periods can be changed to "in use" state by the user, ineffectively. Aug 2, 2017
@Aquaj Aquaj closed this as completed in 31cf198 Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants