Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of tags and tag based exploration #1201

Closed
Catastrophi opened this issue Apr 15, 2019 · 4 comments
Closed

Display of tags and tag based exploration #1201

Catastrophi opened this issue Apr 15, 2019 · 4 comments

Comments

@Catastrophi
Copy link
Contributor

Description of the feature request

In the view mode, tags are shown separated by spaces. This can cause confusion when the tag itself contains a space as a character. This is true for any other separation character if the tag itselft contains that character. It would be bettter if each tag is displayed in its own box, similar to the ones shown in the edit mode.

When one tag is selected, all experiments/items having that tag are shown. Now, what happens if one clicks on another tag?
The selection changes to the items with the new tag, discarding the previos choice.
It would be highly desireable if the new result included items with both tags (and so on...), meanwhile the filter header shows the active tags, which may be eliminated one by one if required.
I understand that this can be done under the search tab, but this point and click approach in the hope page gives an additional option for exploration....

Informations

  • Elabftw version (visible in Sysadmin panel) : 3.0.0-alpha
  • Installation method (git, docker or zip archive) : Docker
  • Operating system + version : Debian 9
  • Browser used (firefox/chrome) : Firefox
@NicolasCARPi
Copy link
Contributor

Hello,

Thanks for your feedback.

I agree with the first point. I have made the necessary changes to display tags in show and view mode like they appear in edit mode.

2019-04-15-174900_444x65_scrot

As for the second point, I'm not sure about it. I can see how it can be useful, but I'm not sure if it would be the expected behavior, as it implies a different behavior on tag click depending on a previous action, which may be confusing for some users. They way I see it, one would need to shift click the second tag to add it to the filter list, this way the user asks for the modified behavior.

I would recommend using the search page if you need multiple tag search. I'm planning to revamp the tag block on the search page, as the current solution doesn't scale very well.

As a side note, did the update to 3.0.0 went smoothly? (I'm guessing yes or you would have opened an issue :) )

@Catastrophi
Copy link
Contributor Author

I'm not sure if it would be the expected behavior

This is what needs to be figured out first.

I was imagining it in a different way: Each time a tag is clicked, the clicked tag appears in a box (with a cross mark to remove it ) in the space between Experiment/databse->create new and filter status and the filtered results are shown.

Still tinkering with 3.0.0. The update was smooth and no problems encountered so far.

@NicolasCARPi
Copy link
Contributor

Mmm ok I see what you mean.

@NicolasCARPi
Copy link
Contributor

Note: this issue will auto close once the code is merged to master. You'll need to reopen it, or open a new one specifically for this tag filter feature.

NicolasCARPi added a commit that referenced this issue Apr 17, 2019
* hypernext:
  show upload datetime in view mode. see #1210
  add mathjax in revisions. see #1209
  composer update
  cleanup tags css and trim tag on save
  packages update
  fixup tag css
  fix entries being too high
  little cleanup
  add mention plugin to ucp template editor. fix #1200
  fix phpcs violations
  add boxes around tags, fix #1201
  use php7.2
  regenerate thumbnail when file is replaced
  fix trash not aligned on new todo item
  fix doodle editable comment not available after upload
  yarn upgrade
  upgrade jquery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants