Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments not considered for revision? #1209

Closed
Catastrophi opened this issue Apr 17, 2019 · 2 comments
Closed

Attachments not considered for revision? #1209

Catastrophi opened this issue Apr 17, 2019 · 2 comments

Comments

@Catastrophi
Copy link
Contributor

Description of the problem

Hello @NicolasCARPi ,

The file attachments appears to be not considered for revision. The body of the experiment can be reverted back to a previous state, but all the attachments are kept at all times.

If new versions of files were uploaded at at any time, the previous versions cannot be restored. The replacement is definitive. Is this the way it is intended to work? If yes, this should be mentioned in the manual.

Given storing multple copies of files may cost storage, a practical solution would be to display the name and upload time/ modification time of each file in the revisions, while keeping all files as in the present case. (A timeline for attachments)
Also, please call mathjax in the revisions page.

Informations

  • Elabftw version (visible in Sysadmin panel) : 3.0.0
  • Installation method (git, docker or zip archive) : docker
  • Operating system + version : Debian 9
  • Browser used (firefox/chrome) : Firefox
@NicolasCARPi
Copy link
Contributor

Is this the way it is intended to work?

Yes, because:

storing multiple copies of files may cost storage

a practical solution would be to display the name and upload time/ modification time of each file in the revisions, while keeping all files as in the present case. (A timeline for attachments)

I'll see what can be done.

please call mathjax in the revisions page

Done.

NicolasCARPi added a commit that referenced this issue Apr 17, 2019
* hypernext:
  show upload datetime in view mode. see #1210
  add mathjax in revisions. see #1209
  composer update
  cleanup tags css and trim tag on save
  packages update
  fixup tag css
  fix entries being too high
  little cleanup
  add mention plugin to ucp template editor. fix #1200
  fix phpcs violations
  add boxes around tags, fix #1201
  use php7.2
  regenerate thumbnail when file is replaced
  fix trash not aligned on new todo item
  fix doodle editable comment not available after upload
  yarn upgrade
  upgrade jquery
@NicolasCARPi
Copy link
Contributor

A timeline for attachments

This would mean having a table for tracking uploads changes. I won't implement it. Incremental backups of the uploaded files could be a valid out-of-code solution to this feature request. As a bonus, you get the old version of files.

Tracking file changes would make more sense if the previous versions of the files were kept. But it's not going to happen right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants