Fix ove and issues with uploadsDiv and the observer #4867
Conversation
don't observe the subtree
* hypernext: add a notification when new version has been updated after login add configurable chat room link add emit_audit_logs instance config to emit audit logs as NOTICE in php add import/export audit log event try and fix issue with multiple data-trigger listeners on the page add requester info to Users2Teams class
|
Hello Marcel, Thank you for this. It seems the button to toggle display mode of uploads isn't working properly anymore, and I see an error from autoload.ts of 3dmol:
So this probably needs more work! |
|
So the toggle display button becomes functional again if the reloadElement call targets |
The toggle button is fixed now.
I could not reproduce this error. Let me know if that is still an issue. Works for me with Firefox.
The problem is that the mutation observer will run into an infinite loop if both options ( For chemdoodle to work with the changes made here, PR deltablot/chemdoodle-web-mini#2 is necessary. |
|
Try and add a .pdb such as https://raw.githubusercontent.com/NicolasCARPi/example-files/master/example.pdb Then reload the page: It looks like it's trying to load the file from rcsb.org for some reason.... |
|
Removing the first autload call seems to fix this pdb issue... |
We have data attributes that are conflicting with 3Dmol. Compare to their docs https://3dmol.org/doc/tutorial-embeddable.html |
* hypernext: fix required label not appearing on all elements Fix ove and issues with uploadsDiv and the observer (#4867) Avoid casting in favor of getString and get Int; harmonization of the use of App->Request (#4872) fix drag and drop issues when uploads in table display mode add sysconfig setting to prevent admins from archiving users add a notification when new version has been updated after login add configurable chat room link add emit_audit_logs instance config to emit audit logs as NOTICE in php add import/export audit log event try and fix issue with multiple data-trigger listeners on the page add requester info to Users2Teams class simplify function notation don't disable the timestamp button on click always display main text + extra fields in toggle body in show mode add custom_id to CSV export add owner parameter for GET all add diff syntax highlighting add `metadata_decoded` to JSON output for single entity Fix the tinyMCE mention plugin (#4852)
Hi Nico,
The fix for ove was rather easy. Turns out ove is now adding messages also in case of successfully parsing a file.
But the rest of this PR was a bit tedious. It looks like you have been there recently as well (#4843).
We better don't observe the subtree!
I undid stuff that is related to:
But maybe this needs a bit more cleanup? What do you think?
closes #4863