Avoid casting in favor of getString and get Int; harmonization of the use of App->Request #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prefer to use `$App->Request` over `$Request`
NicolasCARPi
added a commit
that referenced
this pull request
Jan 20, 2024
* hypernext: fix required label not appearing on all elements Fix ove and issues with uploadsDiv and the observer (#4867) Avoid casting in favor of getString and get Int; harmonization of the use of App->Request (#4872) fix drag and drop issues when uploads in table display mode add sysconfig setting to prevent admins from archiving users add a notification when new version has been updated after login add configurable chat room link add emit_audit_logs instance config to emit audit logs as NOTICE in php add import/export audit log event try and fix issue with multiple data-trigger listeners on the page add requester info to Users2Teams class simplify function notation don't disable the timestamp button on click always display main text + extra fields in toggle body in show mode add custom_id to CSV export add owner parameter for GET all add diff syntax highlighting add `metadata_decoded` to JSON output for single entity Fix the tinyMCE mention plugin (#4852)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nico,
Because of your comment #4835 (comment) there is this PR now. It will
getStringorgetInt. In some casessprintfis used.App->Requestis preferred overRequest, this should be the same no everywhere.no-unused-disable.