Sync linters configurations with HA core #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetienne
commented
Jan 11, 2023
| - --quiet | ||
| files: ^((homeassistant|script|tests)/.+)?[^/]+\.py$ | ||
| files: ^((custom_components)/.+)?[^/]+\.py$ |
There was a problem hiding this comment.
That was the main issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The pre-commit configuration that was copied from home assistant was not correct for this repository. I update it with the same rules that HA core and fix all the violations.
The idea is to have the same code quality than the one we can see on the Core. For the moment, I didn’t enable the rules related to the documentation. There was indeed to much to do, and this PR already introduce a lot of modifications.
I plan also to add pylint.