-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread safety #125
Merged
Merged
Thread safety #125
Commits on May 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2c1b52c - Browse repository at this point
Copy the full SHA 2c1b52cView commit details
Commits on May 28, 2022
-
Removed static vector for thread safety. Accessing the original mesh ID can now be done by `originalID[meshID]`, where `originalID` is a field of `MeshRelation`. Note that `meshID` will not be updated when a manifold is cloned. Instead, it is only used to identify triangles coming from different manifolds when doing boolean operations/compose.
Configuration menu - View commit details
-
Copy full SHA for bd48946 - Browse repository at this point
Copy the full SHA bd48946View commit details -
Disabled most of the importer/exporter formats by default, for faster development and CI. Note that you may need to CMakeCache.txt for this to take effect, as the options might be cached.
Configuration menu - View commit details
-
Copy full SHA for d4be350 - Browse repository at this point
Copy the full SHA d4be350View commit details -
removed originalID from public API
... at the expense of the internal code becoming a bit less intuitive. The meshID in the internal API is purely internal, usually starting from 0, which is used for differentiating between triangles coming from different meshes. originalID can map this internal meshID to the external meshID, and such mapping is automatically done when calling `GetMeshRelation`, so users don't have to care about this mapping. As a bonus, we don't need to deal with atomics when manipulating meshIDs internally: we can use whatever IDs we want as long as the mapping is preserved and distinct for triangles coming from different meshes. I also made the meshID modification code run in the device, which should be faster for larger meshes.
Configuration menu - View commit details
-
Copy full SHA for 5ef76f6 - Browse repository at this point
Copy the full SHA 5ef76f6View commit details
Commits on May 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1d7f22d - Browse repository at this point
Copy the full SHA 1d7f22dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93135d9 - Browse repository at this point
Copy the full SHA 93135d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d19d38 - Browse repository at this point
Copy the full SHA 7d19d38View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc7f8dc - Browse repository at this point
Copy the full SHA bc7f8dcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.