Set up test for subtraction of a very large cuboid #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test case for #712 - these glb inputs were generated from manifolds that succeeded in producing a Boolean output, but (on one platform but not another) the Status() call on the output boolean manifold crashed. (A test for calling Status() on the output captured on the crashing platform (in case there was something specifically bad about that particular output on that platform) was tried, but the result was simply a successful Status() call even with that specific input - hence, that additional test is not included in this commit.)
|
Looks like we caught the problem here, thanks! I'll take a look. |
|
I have a local repro of this problem - for once it's not the triangulator! @pca006132 Might be good to look at this case to get an idea of how to construct fuzzer tests. Speaking of, is there a way to use our fuzzer to minimize this test case? |
|
No, this is not something fuzzer can do. We can probably write something that simplifies the triangular mesh though. |
|
Closing in favor of #714. Thanks for a good edge case test! For future reference, please make your PRs on a new branch - we can't merge if you're using master already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case for #712 - these glb inputs were generated from manifolds that succeeded in producing a Boolean output, but (on one platform but not another) the Status() call on the output boolean manifold crashed.
(A test for calling Status() on the output captured on the crashing platform (in case there was something specifically bad about that particular output on that platform) was tried, but the result was simply a successful Status() call even with that specific input - hence, that additional test is not included in this commit.)
Right now we're using the same GetMeshGL() call as the other tests, but perhaps it would be preferable to use Status() instead since that was the observed failure? I wasn't sure if the former was preferred as a more rigorous test of the Manifold structure.