Godot patches #93
Merged
Godot patches #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
fire
commented
Apr 19, 2022
fire
commented
Apr 19, 2022
fire
commented
Apr 19, 2022
fire
force-pushed
the
godot-patches
branch
3 times, most recently
from
d5c6a5a
to
0cf5739
Compare
|
@elalish |
elalish
requested changes
Apr 19, 2022
|
CUDA compilation work on my machine, so i may just need to update the version of CUDA on the CI. |
|
Rebased. Needs cicd approval. Also, do geometry tests run on github actions? Edited: I have some things in the queue, so I will pause this until the weekend. |
|
No prob, I should have the graph stuff merged by then, which hopefully will supersede this PR. Yes, all the tests, most of which are geometry, run on the CI. |
|
Is this needed anymore now that #92 is merged? |
|
Let me check. |
|
@elalish Cicd approval required. |
elalish
reviewed
Apr 21, 2022
elalish
approved these changes
Apr 21, 2022
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
Godot patches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes I did. Pushing for cicd testing.