Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::graph with graphlite #92

Merged
merged 7 commits into from
Apr 21, 2022
Merged

Replace boost::graph with graphlite #92

merged 7 commits into from
Apr 21, 2022

Conversation

elalish
Copy link
Owner

@elalish elalish commented Apr 18, 2022

Since we're only using boost::graph for a simple connected components algorithm anyway, let's simplify the dependency by taking a single-file library.

@elalish elalish self-assigned this Apr 18, 2022
@fire
Copy link
Contributor

fire commented Apr 18, 2022

CMake Error at manifold/CMakeLists.txt:5 (add_library):
  CUDA_STANDARD is set to invalid value '17'

This is odd.

@fire
Copy link
Contributor

fire commented Apr 18, 2022

manifold\src\impl.cu is still using boost https://github.com/elalish/manifold/blob/graphlite/manifold/src/impl.cu#L19-L21

@fire
Copy link
Contributor

fire commented Apr 18, 2022

I'm having some trouble trying to get int Manifold::Impl::InitializeNewReference
to work.

@elalish
Copy link
Owner Author

elalish commented Apr 18, 2022

Sorry, this is a WIP. Just letting you know I'm working on it. I need to deal with the C++17 build stuff first.

This was referenced Apr 19, 2022
@elalish elalish merged commit fd72eb9 into master Apr 21, 2022
@elalish elalish deleted the graphlite branch April 21, 2022 06:56
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
Replace boost::graph with graphlite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants