Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: support for iOS/MacOS, Safari #84

Closed
lkiesow opened this issue Oct 14, 2019 · 8 comments
Closed

Tracking issue: support for iOS/MacOS, Safari #84

lkiesow opened this issue Oct 14, 2019 · 8 comments
Assignees
Labels
tracking-issue Longer lived issued that track the process on a bigger or more general feature

Comments

@lkiesow
Copy link
Contributor

lkiesow commented Oct 14, 2019

Currently, Safari supports getUserMedia (webcam), does not support getDisplayMedia (screen) and partially supports MediaRecorder. The important part is tracking the MediaRecorder support for now.

Current state:

  • MediaRecorder support exists in Safari, but is experimental and must be manually enabled in the browser's settings
  • Users reported Safari on iOS to cresh after approximately 10min, causing the recording to be lost. Shorter recordings seem to work.
  • Mobile Safari always uses the front face camera without asking. See issue Mobile Safari and Chrome always use front face camera without asking #217
  • Video is rotated by 180° in recording

Useful links:

@lkiesow lkiesow added the priority:high High priority label Oct 14, 2019
@lkiesow lkiesow added this to To do in Mobile Support Oct 14, 2019
@luniki
Copy link
Member

luniki commented Oct 22, 2019

see #86

@luniki luniki self-assigned this Oct 22, 2019
@luniki luniki removed their assignment Nov 13, 2019
@lkiesow
Copy link
Contributor Author

lkiesow commented Nov 18, 2019

Not sure what the relationship between this and #86 is except that both issues appear on iOS.

@lkiesow lkiesow added this to To do in Sprint [Week 47] via automation Nov 18, 2019
luniki added a commit that referenced this issue Nov 19, 2019
So we have to detect support before accessing it.

Refs #84
@luniki luniki self-assigned this Nov 19, 2019
@luniki luniki moved this from To do to In progress in Sprint [Week 47] Nov 19, 2019
@luniki
Copy link
Member

luniki commented Nov 20, 2019

I tested this on an iPad running Safari 13.x with an enabled "Experimental Setting" >> "MediaRecorder" and it does work as advertised.
@lkiesow Could you please replicate that and hopefully close this issue?

@luniki luniki moved this from In progress to Review in progress in Sprint [Week 47] Nov 20, 2019
@lkiesow
Copy link
Contributor Author

lkiesow commented Nov 20, 2019

I'm not sure if I understand this correctly. If I remember correctly, iOS worked right at the beginning and some later change broke it right? So, it can generally work without the experimental flag, right?

Having users manually enable an experimental flag in the settings (that's what you want them to do, correct?) is a usability nightmare. We need to find a way around that.

@luniki
Copy link
Member

luniki commented Nov 21, 2019

I'm not sure if I understand this correctly. If I remember correctly, iOS worked right at the beginning and some later change broke it right? So, it can generally work without the experimental flag, right?

According to caniuse this should never have worked. To prove this I setup the old version of OC Studio and tested it with an iPad but it does not work (as expected).

I searched through the WebKit Bugzilla finding this one: (#85851)[https://bugs.webkit.org/show_bug.cgi?id=85851#c43]

So even after Safari released the new Version v13, MediaRecorder still does not work without the experimental flag…

Having users manually enable an experimental flag in the settings (that's what you want them to do, correct?) is a usability nightmare. We need to find a way around that.

You are right. This is a nightmare. But I fear that we cannot find a workaround other than waiting for Apple to fix the problem some day.

@luniki luniki closed this as completed Nov 21, 2019
Mobile Support automation moved this from To do to Done Nov 21, 2019
Sprint [Week 47] automation moved this from Review in progress to Done Nov 21, 2019
@LukasKalbertodt
Copy link
Member

This indeed seems to be impossible right now. I also searched for poly fills, but the ones I found only support audio recording. Developing an own polyfill is probably overkill.

@LukasKalbertodt
Copy link
Member

I just tested this with the experimental flag and the video seems to be rotated by 180°. Not the preview, just the resulting video.

Also: I'd propose to keep this issue open as a tracking issue until iOS is supported.

@LukasKalbertodt LukasKalbertodt changed the title Non-functioning on iOS Tracking issue: support for iOS Nov 21, 2019
Mobile Support automation moved this from Done to In progress Nov 21, 2019
Sprint [Week 47] automation moved this from Done to In progress Nov 21, 2019
@LukasKalbertodt LukasKalbertodt added tracking-issue Longer lived issued that track the process on a bigger or more general feature and removed priority:high High priority labels Nov 21, 2019
@LukasKalbertodt LukasKalbertodt removed this from In progress in Sprint [Week 47] Nov 21, 2019
@LukasKalbertodt LukasKalbertodt changed the title Tracking issue: support for iOS Tracking issue: support for iOS/MacOS, Safari Jan 20, 2020
@LukasKalbertodt
Copy link
Member

I think this can be closed. Safari now (>= 14) supports the MediaRecorder API and all other APIs we require. #935 updates the browser table. It's still suboptimal, but all problems are tracked by other issues, e.g. #517 and #934, or are problems that Studio can definitely not fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking-issue Longer lived issued that track the process on a bigger or more general feature
Projects
No open projects
Mobile Support
  
In progress
Development

No branches or pull requests

3 participants