Improve codec/MIME-type selection #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKalbertodt
force-pushed
the
improve-codec-selection
branch
from
67c8503
to
e02fb44
Compare
For one, currently we prefer vp9 over other codecs. Chrome on Android does support vp9, but encoding is very slow. This leads to ~2fps recordings on non-powerful devices, which is obviously unacceptable. Second, Safari only supports a few special MIME-types. We could special case something for Safari, but we can also let the browser choose the MIME-type. This is a good default. We might want to add "expert settings" later with which advanced users can tweak these things.
LukasKalbertodt
force-pushed
the
improve-codec-selection
branch
from
e02fb44
to
78a31ca
Compare
|
With this PR, recording webcam with audio results in these files/codecs:
I haven't tested bitrate and stuff like that as this PR doesn't change anything about that. This confirms my assumption: the browser selected codecs are fine. And as this solves some issues, I think we should merge this. |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243
Fixes #335
CC #84
This has several advantages and fixes a few things. It's probably a better default than having a list of arbitrary MIME-types and codecs that we choose from. The browser usually has way more knowledge to choose that.
This is still a draft PR as I need to test this on many devices to check if the browser-selected codec is fine.