Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve space usage for dual stream videos in Paella #956

Closed
LukasKalbertodt opened this issue Oct 4, 2023 · 0 comments · Fixed by #985
Closed

Improve space usage for dual stream videos in Paella #956

LukasKalbertodt opened this issue Oct 4, 2023 · 0 comments · Fixed by #985
Labels
area:player Paella and its integration in Tobira

Comments

@LukasKalbertodt
Copy link
Member

If the browser window isn't very tall, then this happens:

image

https://tobira.opencast.org/v/GwB04tlrgOc

A bit of previous discussion: #862
We currently only have the dynamic video layout for single stream videos. Paella docs on video layouts: https://github.com/polimediaupv/paella-core/blob/main/doc/video_layout.md
@LukasKalbertodt LukasKalbertodt added the area:player Paella and its integration in Tobira label Oct 4, 2023
@LukasKalbertodt LukasKalbertodt mentioned this issue Oct 4, 2023
Closed
This was referenced Nov 6, 2023
Merged
Merged
LukasKalbertodt added a commit that referenced this issue Nov 8, 2023
@LukasKalbertodt
Fix paella dual stream layout (#985)
79d7c44 
Closes #956

Before:
<img width="510" alt="Bildschirmfoto 2023-11-06 um 14 06 18"
src="https://github.com/elan-ev/tobira/assets/94838646/669735e4-1c27-4871-972c-97c6402cf28e">

After:
<img width="510" alt="Bildschirmfoto 2023-11-06 um 14 05 56"
src="https://github.com/elan-ev/tobira/assets/94838646/05695a80-2678-464a-9b62-5ef8c459e60f">

~~Two unexpected sideeffects:~~
- ~~The "fullscreen" and "swap" icons somehow changed. Huh?~~ this is
desired and simply part of the dynamic layout it appears. Well it can be
configured as I understand, but these seem to be the default.
- ~~Default layout is now "Presenter" for some reason. Which is
unfortunate. With this, users might think dual stream isn't working.
There must be a way to configure that but I couldn't find it yet.~~
LukasKalbertodt added a commit that referenced this issue Nov 13, 2023
@LukasKalbertodt
Adjust Paella scaling and background (#984)
2e8fb62 
Closes #954 

This is.. the best I could come up with. Might seem weird to infer the
initial video width using it's height and resolution but I don't see a
better way.
I was wondering if this needs a special handling for multi-stream videos
but couldn't make out a difference. Even though there is more space, the
individual streams don't really care to use it (related: #956).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:player Paella and its integration in Tobira
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix paella dual stream layout owi92/tobira
1 participant
@LukasKalbertodt