-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink paella background and/or video scaling #954
Comments
"be it either black or white" I'm fine with this as long as it's white. |
I think it should be dependent on color scheme honestly. Similar to what we have now but with white for light and black for dark mode. |
Keep forgetting this, why is everyone so obsessed with dark mode? You're right of course. |
Additionally to picking a better color, we can also tweak some spacing options such that on common 16:9 viewport sizes for at least 16:9 videos, this doesn't happen. Like my screenshot above: There is almost no letterboxing. I would think we can fairly simply reduce the player page width to fix that. |
Maybe I'm too late here, but to me making it transparent seems as the option to go. As Ole stated, like this it's always the site's background. |
I'm not convinced that transparent/same-as-background is the best option. To me it looks weird that the player control extends further than the video like that. Seems almost broken to me. Compare that to just using black as background. Which, by the way, is also used for thumbnails. Black letterboxing is pretty common in these situations, I would say. YouTube also uses black in the "wide player" mode: And in "narrow player" mode... well it does something. In light mode it's a gradient that looks pretty ugly in my opinion. In dark mode it uses a cool new feature that colors the background according to the primary color in the video, dynamically. And finally, Vimeo (which only has light mode I think?) |
Well, I was in favor of "white" (which is "transparent" to me looking at the light mode of Tobira), but Lukas makes some good points. Let's discuss this in today's meeting. |
We just discussed this in a meeting and decided to:
|
Closes #954 This is.. the best I could come up with. Might seem weird to infer the initial video width using it's height and resolution but I don't see a better way. I was wondering if this needs a special handling for multi-stream videos but couldn't make out a difference. Even though there is more space, the individual streams don't really care to use it (related: #956).
Right now the player interface doesn't completely scale with the video, which means the video container's grey background sometimes shows at the edges. I think we all agree that we don't love the grey background and should find a different color, be it either black or white or transparent (so it's always the site's background and changes with the color scheme).
Unfortunately we can't make the playback bar scale completely as that wouldn't work for portrait videos.
The text was updated successfully, but these errors were encountered: