Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink paella background and/or video scaling #954

Closed
owi92 opened this issue Sep 28, 2023 · 9 comments · Fixed by #984
Closed

Rethink paella background and/or video scaling #954

owi92 opened this issue Sep 28, 2023 · 9 comments · Fixed by #984
Assignees
Labels
area:design Issues specifically about the broader design of the site area:player Paella and its integration in Tobira priority:low Low priority

Comments

@owi92
Copy link
Member

owi92 commented Sep 28, 2023

Right now the player interface doesn't completely scale with the video, which means the video container's grey background sometimes shows at the edges. I think we all agree that we don't love the grey background and should find a different color, be it either black or white or transparent (so it's always the site's background and changes with the color scheme).
Unfortunately we can't make the playback bar scale completely as that wouldn't work for portrait videos.

@owi92 owi92 added priority:low Low priority area:design Issues specifically about the broader design of the site area:player Paella and its integration in Tobira labels Sep 28, 2023
@oas777
Copy link
Collaborator

oas777 commented Sep 28, 2023

"be it either black or white" I'm fine with this as long as it's white.

@owi92
Copy link
Member Author

owi92 commented Sep 28, 2023

I think it should be dependent on color scheme honestly. Similar to what we have now but with white for light and black for dark mode.

@LukasKalbertodt
Copy link
Member

I like black, or almost completely black, in dark mode:

image

@oas777
Copy link
Collaborator

oas777 commented Sep 28, 2023

Keep forgetting this, why is everyone so obsessed with dark mode? You're right of course.

@LukasKalbertodt
Copy link
Member

Additionally to picking a better color, we can also tweak some spacing options such that on common 16:9 viewport sizes for at least 16:9 videos, this doesn't happen. Like my screenshot above: There is almost no letterboxing. I would think we can fairly simply reduce the player page width to fix that.

@dagraf
Copy link
Collaborator

dagraf commented Oct 25, 2023

Maybe I'm too late here, but to me making it transparent seems as the option to go. As Ole stated, like this it's always the site's background.

@LukasKalbertodt
Copy link
Member

I'm not convinced that transparent/same-as-background is the best option. To me it looks weird that the player control extends further than the video like that. Seems almost broken to me.

image
image

Compare that to just using black as background. Which, by the way, is also used for thumbnails. Black letterboxing is pretty common in these situations, I would say.

image
image

YouTube also uses black in the "wide player" mode:

image
image

And in "narrow player" mode... well it does something. In light mode it's a gradient that looks pretty ugly in my opinion. In dark mode it uses a cool new feature that colors the background according to the primary color in the video, dynamically.

image
image

And finally, Vimeo (which only has light mode I think?)

image

@oas777
Copy link
Collaborator

oas777 commented Oct 25, 2023

Well, I was in favor of "white" (which is "transparent" to me looking at the light mode of Tobira), but Lukas makes some good points. Let's discuss this in today's meeting.

@LukasKalbertodt
Copy link
Member

We just discussed this in a meeting and decided to:

  • Use black as background, but
  • Make Tobira's "player rectangle" algorithm smarter so that the player is made narrower as long as all buttons in the player UI still fit. If that's not possible, the player spans the whole page though (and then the black background is visible). Meaning:
    • For portrait mode videos, we will likely not be able to fit all buttons in the narrow width -> full page width and black background.
    • For other videos, like in the first two screenshots of my previous comment, it will be possible to shrink the player horizontally. Thus we will and center it.

@owi92 owi92 self-assigned this Nov 2, 2023
LukasKalbertodt added a commit that referenced this issue Nov 13, 2023
Closes #954 

This is.. the best I could come up with. Might seem weird to infer the
initial video width using it's height and resolution but I don't see a
better way.
I was wondering if this needs a special handling for multi-stream videos
but couldn't make out a difference. Even though there is more space, the
individual streams don't really care to use it (related: #956).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:design Issues specifically about the broader design of the site area:player Paella and its integration in Tobira priority:low Low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants