-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Paella and improve cursor #1041
Update Paella and improve cursor #1041
Conversation
Main change from this: a `pointer` cursor when hovering over the timeline or buttons. Closes elan-ev#707
Not sure whether that's ex-post overthinking on your behalf or "underthinking" when the issue was opened. Anyway, I think it's an improvement for now. If someone wants this reversed/customized for the scenario you describe, they should come forward. |
Paella has a configuration item for hiding/showing the timeline. We should surface that config in Tobira. |
My philosophy for Tobira is to not make things configurable unless there is a good reason to do so. This is all in service of complexity management (which I deem very important in software dev) and consistency. If we can't find a consensus here on whether to hide or show it for live stream videos, sure let's add a config. But at least try to find out whether there is a choice that would work for everyone. Do you have use cases where having the timeline for live events is useful? |
7212989
to
aecefc0
Compare
Oof, good catch, Paella never ceases to amaze me. I just removed the questionable commit, i.e. the "hide timeline for live" is gone now. I will create a separate issue for that, so that we can move along with the important part of this PR. |
Honi soit qui mal y pense. |
Two main visible changes:
pointer
cursor is shown, similar to other video players out there. Fixes Player: Improve usability by showing end of timeline and by changing cursor to hand when hovering over clickable regions #707The timeline is now hidden for live videos. See Update Paella to improve live streams #1003I think the first point is clearly an improvement.
Regarding the second one I'm not sure: some live streams might allow seeking into the past, which wouldn't be possible anymore with this. I'm really not sure whether that's a concern for institutions out there. So yeah, feedback is welcome @dagraf @oas777 @ziegenberg