-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add series to search results #1144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
force-pushed
the
series-search-results
branch
from
March 13, 2024 13:28
4fca63e
to
e7cf14e
Compare
owi92
force-pushed
the
series-search-results
branch
from
March 14, 2024 10:09
14d0648
to
86f5b6d
Compare
LukasKalbertodt
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding shadow: I like it, and could even imagine making it stronger. Same offset, blur of 6px, opacity of 40% for example
owi92
force-pushed
the
series-search-results
branch
2 times, most recently
from
March 18, 2024 21:33
a8b1c21
to
42cc1a2
Compare
owi92
force-pushed
the
series-search-results
branch
from
March 18, 2024 21:48
42cc1a2
to
2cd73a2
Compare
owi92
force-pushed
the
series-search-results
branch
from
March 19, 2024 15:06
2cd73a2
to
c55da47
Compare
LukasKalbertodt
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds series to search results.
Couple of notes:
Closes #360