Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add series to search results #1144

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Mar 13, 2024

This adds series to search results.

Couple of notes:

  • I don't really like the icon chosen for this, but the one I would prefer is not yet included in the icon package used in Tobira.
  • The box shadow for the thumbnails is also debatable. I left it in so you can play around with it and see if you can find a nicer looking one.
  • The series entries look samewhat empty when there is no description, but we discussed adding some metadata like a (potentially shortened) list of creators of events in that series and maybe also/alternatively direct links to the first few events, but this is tbd in another PR.

Closes #360

@owi92 owi92 added the changelog:user User facing changes label Mar 13, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1144 March 13, 2024 13:35 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1144 March 13, 2024 14:23 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1144 March 14, 2024 10:15 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding shadow: I like it, and could even imagine making it stronger. Same offset, blur of 6px, opacity of 40% for example

backend/src/api/model/search/mod.rs Outdated Show resolved Hide resolved
backend/src/api/model/search/mod.rs Outdated Show resolved Hide resolved
backend/src/api/model/search/mod.rs Outdated Show resolved Hide resolved
backend/src/api/model/search/mod.rs Outdated Show resolved Hide resolved
backend/src/api/model/search/mod.rs Outdated Show resolved Hide resolved
frontend/src/routes/Search.tsx Outdated Show resolved Hide resolved
frontend/src/routes/Search.tsx Outdated Show resolved Hide resolved
frontend/src/routes/Search.tsx Outdated Show resolved Hide resolved
frontend/src/routes/Search.tsx Outdated Show resolved Hide resolved
frontend/src/routes/Search.tsx Outdated Show resolved Hide resolved
@owi92 owi92 force-pushed the series-search-results branch 2 times, most recently from a8b1c21 to 42cc1a2 Compare March 18, 2024 21:33
@github-actions github-actions bot temporarily deployed to test-deployment-pr1144 March 18, 2024 21:36 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1144 March 18, 2024 21:52 Destroyed
backend/src/api/model/search/mod.rs Outdated Show resolved Hide resolved
backend/src/api/model/search/mod.rs Show resolved Hide resolved
frontend/src/routes/Search.tsx Outdated Show resolved Hide resolved
frontend/src/ui/Video.tsx Outdated Show resolved Hide resolved
frontend/src/ui/Video.tsx Outdated Show resolved Hide resolved
frontend/src/routes/Search.tsx Outdated Show resolved Hide resolved
frontend/src/ui/Video.tsx Outdated Show resolved Hide resolved
frontend/src/ui/Video.tsx Outdated Show resolved Hide resolved
frontend/src/routes/Search.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to test-deployment-pr1144 March 19, 2024 15:09 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit 7895f81 into elan-ev:master Mar 19, 2024
4 checks passed
@owi92 owi92 deleted the series-search-results branch March 19, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make series findable via search
2 participants